feat: pass --config to cn remote #7592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| idempotencyKey: testIdempotencyKey, | ||
| branchName: testBranch, | ||
| agent: undefined, | ||
| config: undefined, |
Contributor
There was a problem hiding this comment.
Expecting config to be undefined in parsed JSON is incorrect; JSON.stringify omits undefined properties so the key will be absent. Update the test to not expect this property when config is not provided.
Prompt for AI agents
Address the following comment on extensions/cli/src/commands/remote.test.ts at line 240:
<comment>Expecting config to be undefined in parsed JSON is incorrect; JSON.stringify omits undefined properties so the key will be absent. Update the test to not expect this property when config is not provided.</comment>
<file context>
@@ -236,6 +236,71 @@ describe("remote command", () => {
idempotencyKey: testIdempotencyKey,
branchName: testBranch,
+ agent: undefined,
+ config: undefined,
+ });
+ });
</file context>
Contributor
Author
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
so we can use custom agents when starting them remotely
Summary by cubic
Adds a --config flag to cn remote to launch remote sessions with a custom agent/config. The request now includes agent and config fields, and the PR review workflow uses this flag.