Skip to content

feat: warning when running CLI in home dir #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sestinj merged 8 commits into from
Sep 3, 2025
Merged

feat: warning when running CLI in home dir #7536

sestinj merged 8 commits into from
Sep 3, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 3, 2025 •
edited
Loading

Description

CON-3791

image

Summary by cubic

Adds a TUI warning when the CLI is run from the home directory to nudge users into running cn inside a project folder. Headless mode (-p) is unchanged and never shows the warning.

  • New Features
    • Show a yellow “Run cn in a project directory…” warning in the Intro screen when cwd matches the user’s home (using path-resolved checks).
    • Export HOME_DIRECTORY_WARNING and add e2e tests covering TUI vs headless behavior, cross-platform envs, symlink/relative paths, and missing home vars.

@RomneyDa RomneyDa requested a review from a team as a code owner September 3, 2025 01:02
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team September 3, 2025 01:02
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

⚠️ AI review completed but no review output was generated. Check the action logs for details.

💡 To request a new review, comment @continue-general-review

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 issues found across 2 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@RomneyDa
Copy link
Collaborator Author

RomneyDa commented Sep 3, 2025 •
edited
Loading

Addressed cubic feedback:

  • IntroMessage: compare home vs cwd case-insensitively on win32
  • e2e: avoid using real home as cwd; isolate via temp dir and CONTINUE_GLOBAL_DIR
  • e2e: replace '~' test with canonical alt path; add realpath symlink case
  • e2e: in 'home cannot be determined' test, mask HOME/USERPROFILE/HOMEDRIVE/HOMEPATH with empty strings

All e2e tests for this suite pass locally: npm run test:e2e -w extensions/cli -- -t "Home Directory Warning".

Generated by cn

@sestinj sestinj merged commit 1ff23a6 into main Sep 3, 2025
61 of 70 checks passed
@sestinj sestinj deleted the dallin/home-dir-warning branch September 3, 2025 03:30
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Sep 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Sep 3, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 3, 2025

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@tomasz-stefaniak tomasz-stefaniak Awaiting requested review from tomasz-stefaniak tomasz-stefaniak is a code owner automatically assigned from continuedev/continue-code-reviewers

Assignees

No one assigned

Labels

released size:L This PR changes 100-499 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomneyDa @sestinj