-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: pause and resume cn #7501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 8 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
|
||
| describe("TUIChat - Interruption UI (Minimal Test)", () => { | ||
| beforeEach(() => { | ||
| vi.useFakeTimers(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary use of fake timers in tests; no timer-based behavior is exercised, so this adds complexity without benefit. Consider removing to avoid brittle interactions with async code.
Prompt for AI agents
Address the following comment on extensions/cli/src/ui/__tests__/TUIChat.interruption.minimal.test.tsx at line 9:
<comment>Unnecessary use of fake timers in tests; no timer-based behavior is exercised, so this adds complexity without benefit. Consider removing to avoid brittle interactions with async code.</comment>
<file context>
@@ -0,0 +1,198 @@
+
+describe("TUIChat - Interruption UI (Minimal Test)", () => {
+ beforeEach(() => {
+ vi.useFakeTimers();
+ });
+
</file context>
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Pause and resume rather than interrupt cn
Summary by cubic
Switches CLI chat interruption from a hard stop to a pause/resume flow so users can press Enter to continue the last response without losing context. Also improves /info to show the current session.