Skip to content

feat: allow/blocklisted blocks in unrollAssistant #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sestinj merged 3 commits into from
Aug 25, 2025
Merged

feat: allow/blocklisted blocks in unrollAssistant #7400

sestinj merged 3 commits into from
Aug 25, 2025

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Aug 25, 2025 •
edited by cubic-dev-ai bot
Loading

Description

feat: allow/blocklisted blocks in unrollAssistant

Summary by cubic

Add allowlist and blocklist support to unrollAssistant to restrict which registry blocks can be used. Checks apply to slug-based "uses" blocks; file-based blocks are not affected and continue to work.

  • New Features
    • Added allowlistedBlocks and blocklistedBlocks options to unrollAssistant/unrollBlocks.
    • If an allowlist is provided, only those slugs are permitted; any block on the blocklist is rejected.
    • Disallowed blocks return clear errors including the owner/package slug via result.errors.
    • Defaults remain unchanged when no lists are provided.
    • Tests cover blocklisted, not-allowlisted, allowed, and file-based scenarios.

@sestinj sestinj requested a review from a team as a code owner August 25, 2025 22:15
@sestinj sestinj requested review from tingwai and removed request for a team August 25, 2025 22:15
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 25, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@sestinj @cubic-dev-ai
Update packages/config-yaml/src/__tests__/index.test.ts
1ae96a6 
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 25, 2025
@sestinj sestinj merged commit c9ecefa into main Aug 25, 2025
82 of 84 checks passed
@sestinj sestinj deleted the nate/unroll-assistant-list-blocks branch August 25, 2025 23:16
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Aug 25, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Aug 25, 2025

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Aug 27, 2025

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

+1 more reviewer

@tingwai tingwai tingwai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sestinj @tingwai