feat: --prompt flag #7358
Merged
feat: --prompt flag #7358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const finalMessage = await processAndCombinePrompts(additionalPrompts, initialPrompt); | ||
|
|
||
| if (finalMessage) { | ||
| handleUserMessage(finalMessage); |
Contributor
There was a problem hiding this comment.
Unhandled promise rejection: handleUserMessage not awaited inside async function
Prompt for AI agents
Address the following comment on extensions/cli/src/ui/hooks/useChat.ts at line 173:
<comment>Unhandled promise rejection: handleUserMessage not awaited inside async function</comment>
<file context>
@@ -163,10 +164,19 @@ export function useChat({
useEffect(() => {
// Only handle initial prompt after chat history is initialized
// This prevents race conditions where the prompt runs before system message is loaded
- if (initialPrompt && isChatHistoryInitialized) {
- handleUserMessage(initialPrompt);
+ if ((initialPrompt || (additionalPrompts && additionalPrompts.length > 0)) && isChatHistoryInitialized) {
+ const processPrompts = async () => {
+ const { processAndCombinePrompts } = await import("../../util/promptProcessor.js");
+ const finalMessage = await processAndCombinePrompts(additionalPrompts, initialPrompt);
</file context>
extensions/cli/src/args.ts
Outdated
| result.prompts = []; | ||
| for (const promptIndex of promptIndices) { | ||
| if (promptIndex + 1 < args.length) { | ||
| result.prompts.push(args[promptIndex + 1]); |
Contributor
There was a problem hiding this comment.
Prompt parsing incorrectly captures flag names as prompt values when no value is provided
Prompt for AI agents
Address the following comment on extensions/cli/src/args.ts at line 187:
<comment>Prompt parsing incorrectly captures flag names as prompt values when no value is provided</comment>
<file context>
@@ -170,8 +172,25 @@ export function parseArgs(): CommandLineArgs {
}
}
+ // Get prompts from --prompt flags (can be specified multiple times)
+ const promptIndices: number[] = [];
+ for (let i = 0; i < args.length; i++) {
+ if (args[i] === "--prompt") {
+ promptIndices.push(i);
+ }
</file context>
| import { Minimatch } from "minimatch"; | ||
|
|
||
| import { processRule } from "./args.js"; | ||
| import { processPromptOrRule } from "./args.js"; |
Contributor
There was a problem hiding this comment.
Incomplete function rename may break existing tests and mocks that still reference the old 'processRule' function name
Prompt for AI agents
Address the following comment on extensions/cli/src/systemMessage.ts at line 8:
<comment>Incomplete function rename may break existing tests and mocks that still reference the old 'processRule' function name</comment>
<file context>
@@ -5,7 +5,7 @@ import * as path from "path";
import pkg from "ignore-walk";
import { Minimatch } from "minimatch";
-import { processRule } from "./args.js";
+import { processPromptOrRule } from "./args.js";
import { serviceContainer } from "./services/ServiceContainer.js";
import { ConfigServiceState, SERVICE_NAMES } from "./services/types.js";
</file context>
|
|
||
| import { parseArgs, processPrompt } from "./args.js"; | ||
|
|
||
| describe("args --prompt flag", () => { |
Contributor
There was a problem hiding this comment.
Missing afterAll hook to restore original process.argv could affect other test suites
Prompt for AI agents
Address the following comment on extensions/cli/src/args.prompt.test.ts at line 5:
<comment>Missing afterAll hook to restore original process.argv could affect other test suites</comment>
<file context>
@@ -0,0 +1,49 @@
+import { describe, it, expect, beforeEach } from "vitest";
+
+import { parseArgs, processPrompt } from "./args.js";
+
+describe("args --prompt flag", () => {
+ beforeEach(() => {
+ // Reset process.argv for each test
</file context>
| configPath?: string; | ||
| organizationSlug?: string; | ||
| additionalRules?: string[]; | ||
| additionalPrompts?: string[]; |
Contributor
There was a problem hiding this comment.
Rule violated: React Re-renders
Array prop in useEffect dependency may cause excessive re-renders if not properly memoized
Prompt for AI agents
Address the following comment on extensions/cli/src/ui/index.ts at line 18:
<comment>Array prop in useEffect dependency may cause excessive re-renders if not properly memoized</comment>
<file context>
@@ -15,6 +15,7 @@ interface StartTUIChatOptions {
configPath?: string;
organizationSlug?: string;
additionalRules?: string[];
+ additionalPrompts?: string[];
toolPermissionOverrides?: {
allow?: string[];
</file context>
| initialPrompt?: string; | ||
| resume?: boolean; | ||
| additionalRules?: string[]; | ||
| additionalPrompts?: string[]; |
Contributor
There was a problem hiding this comment.
Rule violated: React Re-renders
Adding additionalPrompts to interface without preventing re-renders from array reference changes
Prompt for AI agents
Address the following comment on extensions/cli/src/ui/AppRoot.tsx at line 12:
<comment>Adding additionalPrompts to interface without preventing re-renders from array reference changes</comment>
<file context>
@@ -9,6 +9,7 @@ interface AppRootProps {
initialPrompt?: string;
resume?: boolean;
additionalRules?: string[];
+ additionalPrompts?: string[];
}
</file context>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Contributor
Author
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--prompt flag to pass a prompt from the hub
Summary by cubic
Adds a repeatable --prompt flag to the CLI to preload one or more prompts from files, Hub slugs, or raw strings, combined into the initial user message in both TUI and headless modes.
New Features
Dependencies