Skip to content

Conversation

@jpoly1219
Copy link
Contributor

@jpoly1219 jpoly1219 commented Aug 15, 2025

Description

Closes CON-3524.

Fixes fallback theme to work properly.
Add a utility function to turn theme names to kebab case.

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

core/utils/text.vitest.ts


Summary by cubic

Fixes theme fallback so unsupported themes now use dark-plus, keeping code rendering consistent. Also adds a theme name normalizer for safer lookups. Addresses CON-3524.

  • Bug Fixes

    • CodeRenderer now falls back to dark-plus when a theme is missing or unsupported, and always initializes the highlighter after choosing the theme.
    • Normalizes theme names with kebabOfThemeStr and maps “Default Dark Modern” to dark-plus.
  • New Features

    • Added kebabOfThemeStr to normalize theme names (spaces/underscores to hyphens, remove parentheses).
    • Added unit tests for kebabOfThemeStr (core/util/text.vitest.ts).

@jpoly1219 jpoly1219 requested a review from a team as a code owner August 15, 2025 21:07
@jpoly1219 jpoly1219 requested review from Patrick-Erichsen and removed request for a team August 15, 2025 21:07
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 15, 2025
@github-actions
Copy link

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 15, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 15, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 6c9f66c into main Aug 15, 2025
65 of 67 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the jacob/con-3524 branch August 15, 2025 21:46
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants