Skip to content

feat: tool call status icon for search and replace UI #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Patrick-Erichsen merged 1 commit into from
Aug 13, 2025
Merged

feat: tool call status icon for search and replace UI #7112

Patrick-Erichsen merged 1 commit into from
Aug 13, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Aug 13, 2025 •
edited
Loading

Description

  • Shows red X if search and replace fails, and green checkmark if it is completed
  • Clicking opens virtual file with output, just like other tool call UIs
  • Also tweaks spacing a bit

Generating args:
image

Pending acceptance:
image

Succeeded Failed (clicking opens output in virtual file):
image

Failed (clicking opens error in virtual file):
image

Summary by cubic

Added status icons to the search and replace tool call UI to show success or failure, and made the output clickable to open a virtual file.

  • UI Improvements
    • Shows a green checkmark for completed calls and a red X for failed ones.
    • Clicking the icon opens the output in a virtual file.
    • Adjusted spacing for better layout.

@RomneyDa RomneyDa requested a review from a team as a code owner August 13, 2025 02:07
@RomneyDa RomneyDa requested review from tingwai and removed request for a team August 13, 2025 02:07
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 13, 2025
@github-actions
Copy link

github-actions bot commented Aug 13, 2025

Code Review Summary

✅ Strengths

  • Consistent UI/UX: The changes provide a consistent way to display tool call status icons across code blocks, improving visual feedback for users
  • Reusable Components: Good use of existing utilities like getStatusIcon and renderContextItems from shared modules
  • Type Safety: Proper TypeScript typing throughout with optional props and appropriate prop drilling
  • Interactive Features: Nice addition of click handler to view tool call output in a virtual file when available
  • Styling Consistency: Maintains consistent padding and layout patterns across components

⚠️ Issues Found

Low

  • Unused Props in EditFile: The output and status props are passed to EditFile component but never used within the component itself
  • Padding Inconsistency: The PR introduces some padding changes that may affect existing layouts (e.g., changing from px-4 py-1 to just py-1 wrapper)

💡 Suggestions

  • Prop Cleanup: Consider removing the unused output and status props from EditFile component since they're not being utilized
  • Error Handling: The click handler for showing virtual files could benefit from error handling in case renderContextItems throws
  • Component Documentation: Consider adding JSDoc comments for the new showToolCallStatusIcon prop to explain when it should be enabled
  • Testing: The PR would benefit from unit tests for the new tool call status icon functionality, especially the conditional rendering logic

🚀 Overall Assessment

APPROVE

This is a well-implemented feature that enhances the user experience by providing visual feedback for tool call statuses. The code follows existing patterns, maintains type safety, and integrates cleanly with the existing codebase. The minor issues identified are not critical and can be addressed in follow-up PRs.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 7 files. Review in cubic

Patrick-Erichsen
Patrick-Erichsen approved these changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements here!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 13, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit c7fdfe4 into main Aug 13, 2025
40 of 41 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/search-replace-error-clickable branch August 13, 2025 03:22
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Aug 13, 2025
@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@Patrick-Erichsen Patrick-Erichsen Patrick-Erichsen approved these changes

@tingwai tingwai Awaiting requested review from tingwai tingwai is a code owner automatically assigned from continuedev/continue-code-reviewers

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RomneyDa @sestinj @Patrick-Erichsen