Skip to content

Conversation

@bdougie
Copy link
Collaborator

@bdougie bdougie commented Jul 30, 2025

Description

[ What changed? Feel free to be brief. ]

Screenshots on the @ docs page were broken. This PR fixes those and uncomments the Chromium details.

Screenshot 2025-07-29 at 6 47 41 PM

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

  1. View the site on https://www.dropbox.com/scl/fi/nobt84eeyjmqsyqmahpq4/Screenshot-2025-07-29-at-6.47.41-PM.png?rlkey=6iow5zg8yc9qdte50kvz4iuaz&dl=0
  2. Confirm there are no broken images
  3. Confirm the Chromium context is correct or useful.

Summary by cubic

Fixed broken screenshot links on the @docs page and updated Chromium crawling details in the documentation.

@bdougie bdougie requested a review from a team as a code owner July 30, 2025 01:46
@bdougie bdougie requested review from tingwai and removed request for a team July 30, 2025 01:46
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 30, 2025
@bdougie bdougie requested review from Patrick-Erichsen and removed request for tingwai July 30, 2025 01:48
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2025
@bdougie bdougie changed the title docs: Fix broken screenshots on @docs page docs: Fix broken @docs page images and info block Jul 30, 2025
@bdougie bdougie merged commit c8639ac into main Jul 30, 2025
39 checks passed
@bdougie bdougie deleted the bdougie/con-3114 branch July 30, 2025 01:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2025
@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants