Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Jul 25, 2025

Description

Oauth support for MCP

closes CON-2672

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

feat.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Added OAuth support for MCP by spinning up a local server to handle authentication redirects and integrating the flow with the VS Code extension.

  • New Features
    • Local server listens for OAuth redirects and forwards them to VS Code.
    • New MCPOauth class manages the OAuth process for MCP servers.

- spin up a local server to handle redirects
- create an MCPOauth class to handle oauths
@uinstinct uinstinct marked this pull request as ready for review July 29, 2025 11:47
@uinstinct uinstinct requested a review from a team as a code owner July 29, 2025 11:47
@uinstinct uinstinct requested review from RomneyDa and removed request for a team July 29, 2025 11:47
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 29, 2025
RomneyDa
RomneyDa previously approved these changes Jul 30, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds suppot for oauth for MCP servers!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2025
@RomneyDa
Copy link
Collaborator

RomneyDa commented Aug 6, 2025

@uinstinct we noticed that the linear mcp which requires OAuth works with the current extension

It seems like maybe the npm modelcontextprotocol package supports this oauth pattern out of the box. I'll close this for now but we should revisit if there's functionality missing

@RomneyDa RomneyDa closed this Aug 6, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
@RomneyDa RomneyDa reopened this Aug 6, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Issues and PRs Aug 6, 2025
@RomneyDa
Copy link
Collaborator

RomneyDa commented Aug 6, 2025

Reopened since the respons linear works is it uses npx mcp-remote

@RomneyDa
Copy link
Collaborator

RomneyDa commented Aug 7, 2025

@uinstinct trying this out, could you tweak to make the tooltip just Authenticate text and the little icon the clickable part?

image

@RomneyDa
Copy link
Collaborator

RomneyDa commented Aug 7, 2025

@uinstinct Fails with the sentry MCP server, appears that it's because of the redirect URL which does not hit anything

Noticed this comment which seems relavent

// TODO: this has to be a hub url or should we spin up a server?

e.g. approval redirects to
http://localhost:3000/?code=xxx

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comments

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Aug 7, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works with https://hub.continue.dev/dallin/linear-sse
Note, doesn't work with Sentry MCP (405), but seems to be an exception, can iterate as needed

@RomneyDa RomneyDa merged commit 08842da into continuedev:main Aug 13, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2025
@uinstinct uinstinct deleted the mcp-oauth branch August 13, 2025 02:54
@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants