Skip to content

feat: crJson binding on Reader in C FFI#2212

Merged
tmathern merged 1 commit into
mainfrom
mathern/crjson-c-ffi
Jun 8, 2026
Merged

feat: crJson binding on Reader in C FFI#2212
tmathern merged 1 commit into
mainfrom
mathern/crjson-c-ffi

Conversation

@tmathern

@tmathern tmathern commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Changes in this pull request

crJson binding on Reader in C FFI. Pre-requisite to enable bindings in downstream SDKs, especially C++.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@tmathern tmathern requested review from gpeacock and lrosenthol June 5, 2026 23:33
@tmathern tmathern self-assigned this Jun 5, 2026
@tmathern tmathern added safe to test check-release Add this label to any PR to invoke a larger suite of tests. labels Jun 5, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 64 skipped benchmarks1


Comparing mathern/crjson-c-ffi (ddce037) with main (e842fb0)

Open in CodSpeed

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@lrosenthol lrosenthol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmathern tmathern merged commit 402394f into main Jun 8, 2026
152 checks passed
@tmathern tmathern deleted the mathern/crjson-c-ffi branch June 8, 2026 15:02
@caiopensrc caiopensrc mentioned this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-release Add this label to any PR to invoke a larger suite of tests. safe to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants