Skip to content

fix: Dup redaction#2199

Merged
mauricefisher64 merged 6 commits into
mainfrom
dup_redaction
Jun 3, 2026
Merged

fix: Dup redaction#2199
mauricefisher64 merged 6 commits into
mainfrom
dup_redaction

Conversation

@mauricefisher64

@mauricefisher64 mauricefisher64 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request

If we already have recorded a redaction for the assertion don't do it again. This avoids false error when an item is already redacted.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov

codecov Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.48%. Comparing base (bf3aa9c) to head (d6833d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
+ Coverage   78.45%   78.48%   +0.02%     
==========================================
  Files         176      176              
  Lines       46148    46238      +90     
==========================================
+ Hits        36205    36289      +84     
- Misses       9943     9949       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 64 skipped benchmarks1

Comparing dup_redaction (d6833d7) with main (e42dca0)

Open in CodSpeed

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mauricefisher64 mauricefisher64 changed the title Dup redaction fix: Dup redaction Jun 2, 2026
@mauricefisher64 mauricefisher64 requested a review from tmathern June 2, 2026 19:49
ale-adobe
ale-adobe approved these changes Jun 3, 2026
View reviewed changes
Comment thread sdk/src/store.rs Outdated
@tmathern tmathern added safe to test check-release Add this label to any PR to invoke a larger suite of tests. labels Jun 3, 2026
tmathern
tmathern approved these changes Jun 3, 2026
View reviewed changes
Comment thread sdk/src/store.rs
@mauricefisher64 mauricefisher64 merged commit 8ffbdc6 into main Jun 3, 2026
66 checks passed
@mauricefisher64 mauricefisher64 deleted the dup_redaction branch June 3, 2026 13:40
@caiopensrc caiopensrc mentioned this pull request Jun 3, 2026
Merged
@tmathern tmathern mentioned this pull request Jun 3, 2026
Merged
3 tasks
@caiopensrc caiopensrc mentioned this pull request Jun 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmathern tmathern tmathern approved these changes

@ale-adobe ale-adobe ale-adobe approved these changes

@gpeacock gpeacock Awaiting requested review from gpeacock

@ok-nick ok-nick Awaiting requested review from ok-nick

Assignees

No one assigned

Labels

check-release Add this label to any PR to invoke a larger suite of tests. safe to test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mauricefisher64 @tmathern @ale-adobe