Skip to content

fix!: Remove unused Error variant types#2195

Merged
scouten-adobe merged 4 commits into
mainfrom
prune-errors
Jun 4, 2026
Merged

fix!: Remove unused Error variant types#2195
scouten-adobe merged 4 commits into
mainfrom
prune-errors

Conversation

@scouten-adobe

Copy link
Copy Markdown
Collaborator

Also note that Error, in particular, is likely to experience some churn before 1.0 release.

(Observed while fixing: Remove webcrypto_validator.rs, which was no longer used.)
@scouten-adobe scouten-adobe self-assigned this Jun 1, 2026
@scouten-adobe scouten-adobe changed the title Remove unused Error variant types fix!: Remove unused Error variant types Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.61%. Comparing base (dd7760f) to head (defc1ba).

Files with missing lines Patch % Lines
c2pa_c_ffi/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2195   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files         176      176           
  Lines       46358    46357    -1     
=======================================
  Hits        36444    36444           
+ Misses       9914     9913    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jun 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 64 skipped benchmarks1


Comparing prune-errors (defc1ba) with main (dd7760f)

Open in CodSpeed

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread docs/deprecation-policy.md Outdated

@gpeacock gpeacock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's crazy - I had no idea we had so many obsolete errors!

ok-nick
ok-nick approved these changes Jun 2, 2026
scouten-adobe and others added 2 commits June 3, 2026 16:30
@scouten-adobe scouten-adobe added the check-release Add this label to any PR to invoke a larger suite of tests. label Jun 4, 2026
@scouten-adobe scouten-adobe merged commit e842fb0 into main Jun 4, 2026
106 of 107 checks passed
@scouten-adobe scouten-adobe deleted the prune-errors branch June 4, 2026 01:23
This was referenced Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-release Add this label to any PR to invoke a larger suite of tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants