fix: Harden against unchecked array index in JUMBF brotli box accessor#2192
Merged
Conversation
tmathern
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability
JUMBFSuperBox::data_box_as_brotli_boxatsdk/src/jumbf/boxes.rs:358used direct array indexing (&self.data_boxes[index])A 127-byte JPEG containing a
c2cm(compressed manifest) superbox with a validjumddescription box but zero data boxes triggers a panic during JUMBF parsing, before any cryptographic verification:The caller
CAIManifest::from()at line 1528 expectsNonefor the no-brotli-box case, but the method panicked instead.Fix
Use bounds-checked
.get(index).and_then(...)consistent with the otherdata_box_as_*methods.Verification
Verified against the HackerOne PoC (
poc72_empty_manifest.jpg, 127 bytes):Test added
test_data_box_as_brotli_box_empty_returns_none— constructs an emptyJUMBFSuperBoxand assertsdata_box_as_brotli_box(0)returnsNone.Checklist