This repository was archived by the owner on Apr 3, 2018. It is now read-only.
Merged
Conversation
61ccc3e to
904a467
Compare
Contributor
|
DNM I presume this is WIP. |
904a467 to
1779d25
Compare
Currently when a container with CPU constrains is created using docker, the VM starts with a wrong number of vCPUs, the VM must start with the number of vCPUs specified by `default_vcpus` allowing to the runtime hot add/remove resources as needed. For example if DefaultVCPUs (default_vcpus) is 1 and the container has a constraint of 4 (docker run --cpus 4 ...), the VM must start with 1 vCPU because the runtime hot add 4 vCPUs. Qemu command line example: old: `qemu-system-x86_64 ... -smp 4,cores=1,threads=1,sockets=1,maxcpus=240` new: `qemu-system-x86_64 ... -smp 1,cores=1,threads=1,sockets=1,maxcpus=240` Depends-on: github.com/clearcontainers/runtime#1048 see clearcontainers/runtime#1032 and clearcontainers/runtime#1041 fixes containers#661 Signed-off-by: Julio Montes <julio.montes@intel.com>
1779d25 to
c3ad9c2
Compare
Collaborator
Author
|
@grahamwhaley changes applied, thanks |
sboeuf
approved these changes
Mar 6, 2018
Collaborator
|
Thanks @devimc, this is the follow up we need after your patch for hotplugging CPU was merged. |
Collaborator
|
LGTM
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a container with CPU constrains is created using docker,
the VM starts with a wrong number of vCPUs, the VM must start with the
number of vCPUs specified by
default_vcpusallowing to the runtime hotadd/remove resources as needed.
For example if DefaultVCPUs (default_vcpus) is 1 and the container has
a constraint of 4 (docker run --cpus 4 ...), the VM must start with 1
vCPU because the runtime hot add 4 vCPUs.
Qemu command line example:
old:
qemu-system-x86_64 ... -smp 4,cores=1,threads=1,sockets=1,maxcpus=240new:
qemu-system-x86_64 ... -smp 1,cores=1,threads=1,sockets=1,maxcpus=240Depends-on: github.com/clearcontainers/runtime#1048
see clearcontainers/runtime#1032 and
clearcontainers/runtime#1041
fixes #661
Signed-off-by: Julio Montes julio.montes@intel.com