Skip to content

Add Dev, Nlink, and Ino to pkg/system/Stat struct#916

Closed
rhatdan wants to merge 1 commit intocontainers:masterfrom
rhatdan:stat
Closed

Add Dev, Nlink, and Ino to pkg/system/Stat struct#916
rhatdan wants to merge 1 commit intocontainers:masterfrom
rhatdan:stat

Conversation

@rhatdan
Copy link
Copy Markdown
Member

@rhatdan rhatdan commented May 21, 2021

podman needs to look at the Device, Inode and number of
links of a file, but needs this to work on Windows and
Darwin. We are using this information to determine if
a file is a hard link whe tarring it up.

Add new function FileInfoToStatT to transate a FileInfor into
the StatT struct.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented May 21, 2021

podman needs to look at the Device, Inode and number of
links of a file, but needs this to work on Windows and
Darwin.  We are using this information to determine if
a file is a hard link whe tarring it up.

Add new function FileInfoToStatT to transate a FileInfor into
the StatT struct.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented May 21, 2021

Lets wait for the podman PR to work before merging this. Since I have had a few changes to this found via podman.

@vrothberg
Copy link
Copy Markdown
Member

/hold

Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented May 21, 2021

Turns out @nalind does not like this, since the Windows version is returning bogus data, IE Nlink(), Dev(), Ino() always return 0, and this is wrong. So will implement everything in Podman.

@rhatdan rhatdan closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants