Skip to content

unbreak build on mipsen#635

Merged
giuseppe merged 1 commit intocontainers:masterfrom
siretart:patch-1
May 26, 2020
Merged

unbreak build on mipsen#635
giuseppe merged 1 commit intocontainers:masterfrom
siretart:patch-1

Conversation

@siretart
Copy link
Contributor

Stat_t on MIPS uses 32-bit fields for Dev and Rdev, so we need to cast these to uint64

Inpiration from moby/moby#37490
Example build failure log: https://buildd.debian.org/status/fetch.php?pkg=golang-github-containers-storage&arch=mips64el&ver=1.15.8%2Bdfsg1-1&stamp=1580872314&raw=0

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! @siretart, could you sign the commit?

@giuseppe @nalind @rhatdan PTAL

Stat_t on MIPS uses 32-bit fields for Dev and Rdev, so we need to cast these to uint64

Inpiration from moby/moby#37490
Example build failure log: https://buildd.debian.org/status/fetch.php?pkg=golang-github-containers-storage&arch=mips64el&ver=1.15.8%2Bdfsg1-1&stamp=1580872314&raw=0

Signed-off-by: Reinhard Tartler <siretart@tauware.de>
@siretart
Copy link
Contributor Author

LGTM, thanks for the fix! @siretart, could you sign the commit?

sure thing, done!

@giuseppe
Copy link
Member

LGTM

@giuseppe giuseppe merged commit ed02a9d into containers:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants