scope contiguity checks for idmap to mountProgram presence#2346
Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom Jun 9, 2025
Merged
Conversation
70684ab to
e051598
Compare
Luap99
reviewed
Jun 6, 2025
e051598 to
59a14f8
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtrmac
reviewed
Jun 6, 2025
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
I 100% don’t understand the logic, but I also 100% support making the logic consistent in both locations.
So… ACK?
59a14f8 to
c41981d
Compare
The `SupportsShifting` method signature has been updated to include `uidmap` and `gidmap` parameters. Previously, a driver could only declare general support for shifting. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
this check was initially added for fuse-overlayfs, but it should be overlay decision not centralized in store.go. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The contiguity of ID mappings is a requirement for fuse-overlayfs, do not impose it for the native kernel driver. Closes: containers#2345 Closes: https://issues.redhat.com/browse/RHEL-94967 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
c41981d to
ffb4f15
Compare
Member
Author
|
thanks, addressed the comments and pushed a new version |
Collaborator
|
/lgtm Thanks! |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the check for a contiguous mapping to overlay when a mount program is specified, since this is required only for fuse-overlayfs, not native idmapped mounts.
Closes: https://issues.redhat.com/browse/RHEL-94967
Closes: #2345