idmap: fix first argument to open_tree#2301
idmap: fix first argument to open_tree#2301openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
0 is a valid file descriptor, to ignore the argument we need to use AT_FDCWD. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgwalters
left a comment
There was a problem hiding this comment.
Looks correct to me but how was this not caught before? Presumably you saw a failure somewhere else (podman CI? just guessing?) - I personally like to have at least a basic cookie like that in commit messages.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
no, I've seen it only by looking at the code while working on something else: https://github.com/giuseppe/storage/tree/no-leak-idmapped-lower-layers That is just a WIP for now, it depends on a new kernel patch that will be in the 6.15 version |
0 is a valid file descriptor, to ignore the argument we need to use AT_FDCWD.