feat: add Timestamp to TarOptions#2259
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Feb 20, 2025
Merged
feat: add Timestamp to TarOptions#2259openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
giuseppe
approved these changes
Feb 18, 2025
Member
giuseppe
left a comment
There was a problem hiding this comment.
LGTM, but please squash the two commits
This allows overriding of timestamps for entries within an archive. Signed-off-by: Adam Eijdenberg <adam@continusec.com>
78809a0 to
f51eeb9
Compare
Contributor
Author
|
Squashed and rebased. |
giuseppe
approved these changes
Feb 20, 2025
Member
giuseppe
left a comment
There was a problem hiding this comment.
LGTM
@containers/storage-maintainers PTAL
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aeijdenberg, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows overriding of timestamps for entries within an archive.
TarOptions already includes a number of other overrides, it seemed like a good place to add this one as well.
(am keen to look at getting
buildahto have the ability to emit identical tarballs foroci-archive, and this is the first step)