pkg/system: add mimicked xattr syscalls on FreeBSD#2177
pkg/system: add mimicked xattr syscalls on FreeBSD#2177openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
Conversation
8649e5d to
0405f9f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimminss0, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dfr PTAL |
|
LGTM |
|
Why is this new package wrapping the functions with the same names as ones in |
|
The original intention was to let |
8ff771e to
3adcb26
Compare
mtrmac
left a comment
There was a problem hiding this comment.
I like the general direction of this work.
e4d6567 to
fabd9f4
Compare
|
@mtrmac Ping |
`extattr_list_link` never returns ENOTATTR, so remove the corresponding error handling logic to simplify the code. Signed-off-by: Minseo Kim <kimminss0@outlook.kr>
FreeBSD does not offer xattr system calls, but it can be mimicked using extattr system calls. Signed-off-by: Minseo Kim <kimminss0@outlook.kr>
The lgetxattr(2), lsetxattr(2), and llistxattr(2) syscalls on Linux return ENOTSUP instead of EOPNOTSUPP. The same applies to getxattr(2), setxattr(2), and listxattr(2) on macOS. Note that EOPNOTSUPP and ENOTSUP have the same value in Linux (refer to errno(3)). Signed-off-by: Minseo Kim <kimminss0@outlook.kr>
fabd9f4 to
5015968
Compare
This PR adds mimicked
xattrsystem calls on FreeBSD usingextattr. Previous PR #2170 enabled that compatibility on FreeBSD, but only for a very specific area.EDIT: Sync with the revised changes