overlay: use private directory for composefs mounts#2148
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Oct 24, 2024
Merged
Conversation
Member
|
LGTM |
cgwalters
reviewed
Oct 23, 2024
Contributor
cgwalters
left a comment
There was a problem hiding this comment.
I can believe the patch fixes or helps with the reported bug, but I don't know this code well enough to just drop a lgtm myself yet, and I have some suggested cleanups.
a554144 to
310a64b
Compare
Contributor
|
/lgtm |
Member
|
@giuseppe lint is failing |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
similarly to what we are doing for the merged directory we need to use private directories for the composefs temporary mounts. Otherwise when the id is in an additional store, we attempt to perform the mount without holding an exclusive lock there. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
310a64b to
cfd7619
Compare
Member
Author
|
rebased, it passes now |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similarly to what we are doing for the merged directory we need to use private directories for the composefs temporary mounts. Otherwise when the id is in an additional store, we attempt to perform the mount without holding an exclusive lock there.
Could help with containers/container-libs#124. Can't confirm as I wasn't able to find a reproducer yet.
@cgwalters PTAL, another fix for composefs