Skip to content

Use tar-split/tar/asm.IterateHeaders now that it has been accepted#2116

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
mtrmac:tar-split
Sep 27, 2024
Merged

Use tar-split/tar/asm.IterateHeaders now that it has been accepted#2116
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
mtrmac:tar-split

Conversation

@mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Sep 27, 2024

... instead of our version which makes assumptions on the internal decisions of the tar-split project, and needs heuristics to guess where file padding ends.

... instead of our version which makes assumptions on the
internal decisions of the tar-split project, and needs heuristics
to guess where file padding ends.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@kwilczynski
Copy link
Member

@mtrmac, thank you!

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@kwilczynski: changing LGTM is restricted to collaborators

Details

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Sep 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c90a35b into containers:main Sep 27, 2024
@mtrmac mtrmac deleted the tar-split branch September 28, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants