Assorted nits reported by revive linter#2102
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Sep 26, 2024
Merged
Assorted nits reported by revive linter#2102openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
Conversation
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
t.Fatal[f] stops the execution of the test case immediately, so anything that follows is unreachable code and has no effect. Remove it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Should this be enabling the linter in |
Contributor
Author
This linter is sort of too opinionated, and thus it's best to run it manually and only fix those warnings that make sense. We can, of course, annotate all the warnings that we don't want to fix, and then enable the linter, but I'm not sure it makes sense. |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.