Chunked cleanups#1844
Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom Feb 27, 2024
Merged
Conversation
SetBigData itself calls saveFor; so doing that before raises fewer questions about stale data / stepping over each other. The change in timing is externally-observable, but should hopefully not matter much in practice, because this code is typically called from layerStore.create as a part of an atomic create+populate operation proptected by incompleteFlag. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This mirrors a similar check later in pkg/chunked.GetDiffer, we just fail sooner. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This was referenced Feb 26, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / cleans up some outstanding items from #1627 .
@giuseppe PTAL.