chunked: validate converted images#1794
chunked: validate converted images#1794openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
97e2244 to
ca10e69
Compare
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
I think this works; but really it seems to me that the convert_images boolean (… if it continues to exist in the production version of composefs; I don’t know if that’s the plan) should be handled around the ordinary Store.PutLayer. If nothing else, then it would work with registries which don’t support range requests.
validate that the retrieved data for converted images matches the expected digest. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
ca10e69 to
fa794cb
Compare
|
@mtrmac thanks for the review. I've addressed your comments and pushed a new version |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
thanks! The related change in c/image: |
validate that the retrieved data for converted images matches the expected digest.
The related change in c/image: