copy: add --dest-compress-format and --dest-compress-level#671
Merged
rhatdan merged 2 commits intocontainers:masterfrom Sep 3, 2019
Merged
copy: add --dest-compress-format and --dest-compress-level#671rhatdan merged 2 commits intocontainers:masterfrom
rhatdan merged 2 commits intocontainers:masterfrom
Conversation
mtrmac
reviewed
Jun 11, 2019
Contributor
mtrmac
left a comment
There was a problem hiding this comment.
ACK overall, primarily depending on the design decisions in c/image.
4fffa42 to
d518171
Compare
5b5b4ab to
855608d
Compare
e9be01d to
32915d0
Compare
Member
Author
|
rebased |
5d17f85 to
8956b88
Compare
Member
Author
I've added a test to verify the compressed layer is a .zstd file |
rhatdan
reviewed
Aug 21, 2019
mtrmac
reviewed
Aug 21, 2019
fe54879 to
638dba1
Compare
Member
Author
|
@mtrmac does it look fine now? |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Member
Author
|
can this be reviewed? |
vrothberg
reviewed
Sep 2, 2019
vrothberg
reviewed
Sep 2, 2019
docs/skopeo-copy.1.md
Outdated
|
|
||
| **--dest-compress-format** _format_ Specifies the compression format to use. Supported values are: `gzip` and `zstd`. | ||
|
|
||
| **--dest-compress-level** _format_ Specifies the compression level to use. The value is specific to the compression algorithm used, e.g. for zstd the accepted values are in the range 1-20 (inclusive), while for gzip it is 1-9 (inclusive). Algorithms that don't support the setting, will ignore it. |
Member
There was a problem hiding this comment.
The last sentence is now redundant since we only support gzip and zstd.
add the possibility to specify the format and the level to use when compressing blobs. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the possibility to specify the format and the level to use when
compressing blobs.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com