Stop setting unused build tags#2581
Merged
mtrmac merged 3 commits intocontainers:mainfrom Apr 17, 2025
Merged
Conversation
This removes a safety mechanism, but it's better than inventing a dummy tag value (both here and in c/image). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
c/storage no longer uses this tag after containers/storage#2308 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
No code is consuming this build tag, and it should have been removed in 8d04b4a . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Tests failed. @containers/packit-build please check. |
kolyshkin
reviewed
Apr 16, 2025
.cirrus.yml
Outdated
| memory: 8 | ||
| env: | ||
| BUILDTAGS: &withopengpg 'btrfs_noversion libdm_no_deferred_remove containers_image_openpgp' | ||
| BUILDTAGS: &withopengpg 'libdm_no_deferred_remove containers_image_openpgp' |
Contributor
Contributor
There was a problem hiding this comment.
Saw you did just that, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c/storage no longer uses either of these.
FYI @jnovy : spec file changes