Skip to content

Update an expected error message#2442

Merged
TomSweeneyRedHat merged 1 commit intocontainers:mainfrom
mtrmac:error-change
Nov 20, 2024
Merged

Update an expected error message#2442
TomSweeneyRedHat merged 1 commit intocontainers:mainfrom
mtrmac:error-change

Conversation

@mtrmac
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac commented Oct 14, 2024

containers/image#2595 will change it.

This should work with current c/image; #2441 tests whether it will work with the proposed change.

@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@mtrmac mtrmac marked this pull request as ready for review October 14, 2024 19:17
Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

LGTM
but it looks like a rebase is needed @mtrmac

containers/image#2595 will change it.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Nov 20, 2024

Rebased.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

/approved

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

/lgtm

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

LGTM

@TomSweeneyRedHat TomSweeneyRedHat merged commit 87f199f into containers:main Nov 20, 2024
@mtrmac mtrmac deleted the error-change branch November 21, 2024 14:46
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants