Merged
Conversation
Member
|
You will need something like containers/podman@54b8c4f to fix the packit config to no longer build in envs with go 1.21 |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Closed
1 task
Based on containers/podman@54b8c4f by Paul Holzinger <pholzing@redhat.com> . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
lsm5
approved these changes
Sep 4, 2024
Member
lsm5
left a comment
There was a problem hiding this comment.
LGTM
Not a problem for downstream. We'll simply end up not updating f39 which will be going EOL in maybe a couple of months.
Contributor
Author
|
Thanks! Ready for merging, then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc: @Luap99
@lsm5 PTAL — marking as draft to let you review, to make sure this is not a problem for downstream.