Skip to content

fix(deps): update module github.com/containers/image/v5 to v5.25.0#1903

Merged
mtrmac merged 1 commit intomainfrom
renovate/github.com-containers-image-v5-5.x
Apr 5, 2023
Merged

fix(deps): update module github.com/containers/image/v5 to v5.25.0#1903
mtrmac merged 1 commit intomainfrom
renovate/github.com-containers-image-v5-5.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Feb 9, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/containers/image/v5 require minor v5.24.3-0.20230401101358-e3437f272920 -> v5.25.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Feb 9, 2023
@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented Feb 9, 2023

We actually want #1901.

But, let’s see how Go+Renovate interact… I’d like to try merging the release branch back into main to see if Go versioning can deal with that correctly.

So, please merge #1901 first, and then we’ll see how the tools react.

@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch from 0578996 to 1787089 Compare February 10, 2023 17:27
mtrmac
mtrmac requested changes Feb 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a downgrade, we definitely don’t want this.

@mtrmac mtrmac mentioned this pull request Feb 10, 2023
Merged
@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented Feb 10, 2023

Filed containers/image#1842 as a proposal for what to do, please see details there.

@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch 3 times, most recently from 78d89b7 to 987c2ec Compare February 15, 2023 17:48
@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented Feb 15, 2023

Nope, just merging the release branch into main, while vendoring the dependency before a merge, is not sufficient; Go, and Renovate, don’t automatically figure out that the right update point is the merge commit.

Let’s try that manually…

@mtrmac mtrmac mentioned this pull request Feb 15, 2023
Merged
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.24.1 Update module github.com/containers/image/v5 to v5.24.1 - autoclosed Feb 16, 2023
@renovate renovate bot closed this Feb 16, 2023
@renovate renovate bot deleted the renovate/github.com-containers-image-v5-5.x branch February 16, 2023 08:06
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.24.1 - autoclosed Update module github.com/containers/image/v5 to v5.24.1 Feb 21, 2023
@renovate renovate bot reopened this Feb 21, 2023
@renovate renovate bot restored the renovate/github.com-containers-image-v5-5.x branch February 21, 2023 19:42
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.24.1 Update module github.com/containers/image/v5 to v5.24.2 Feb 21, 2023
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch from 987c2ec to 06ec383 Compare February 21, 2023 23:20
mtrmac
mtrmac requested changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, again, a downgrade.

@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch 10 times, most recently from 79bd01f to ef62332 Compare February 27, 2023 10:51
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch 2 times, most recently from d89a796 to 18a3bae Compare March 6, 2023 20:18
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch 2 times, most recently from db54b45 to 2ac48fb Compare March 16, 2023 23:26
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch 6 times, most recently from a6e5cb8 to 7d5748b Compare March 28, 2023 21:25
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch 2 times, most recently from 7f14ec5 to 2dde9b7 Compare April 1, 2023 10:15
@mtrmac mtrmac mentioned this pull request Apr 1, 2023
Merged
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.24.2 Update module github.com/containers/image/v5 to v5.24.2 - autoclosed Apr 1, 2023
@renovate renovate bot closed this Apr 1, 2023
@renovate renovate bot deleted the renovate/github.com-containers-image-v5-5.x branch April 1, 2023 10:42
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.24.2 - autoclosed Update module github.com/containers/image/v5 to v5.24.2 Apr 5, 2023
@renovate renovate bot reopened this Apr 5, 2023
@renovate renovate bot restored the renovate/github.com-containers-image-v5-5.x branch April 5, 2023 13:21
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.24.2 Update module github.com/containers/image/v5 to v5.25.0 Apr 5, 2023
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch from 2dde9b7 to 4892d7d Compare April 5, 2023 14:18
@renovate renovate bot changed the title Update module github.com/containers/image/v5 to v5.25.0 fix(deps): update module github.com/containers/image/v5 to v5.25.0 Apr 5, 2023
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch from 4892d7d to 67f5b53 Compare April 5, 2023 15:44
@renovate
fix(deps): update module github.com/containers/image/v5 to v5.25.0
b0d339f 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
@renovate renovate bot force-pushed the renovate/github.com-containers-image-v5-5.x branch from 67f5b53 to b0d339f Compare April 5, 2023 16:14
@mtrmac mtrmac merged commit 3ddbfec into main Apr 5, 2023
@renovate renovate bot deleted the renovate/github.com-containers-image-v5-5.x branch April 5, 2023 16:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file locked - please file new issue/PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mtrmac