Skip to content

Improve error message when the the podman service is not enabled#8915

Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom
rhatdan:remote
Jan 10, 2021
Merged

Improve error message when the the podman service is not enabled#8915
openshift-merge-robot merged 1 commit intocontainers:masterfrom
rhatdan:remote

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 8, 2021

Currently if server is not connected, we return an error message that
is confusing users on Mac and Windows boxes. The hope here is to make
it a little easier to discover that a Podman service is required.

This message is similar to what Docker puts out so people might under
stand it better.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Jan 8, 2021

@afbjorklund PTAL

Currently if server is not connected, we return an error message that
is confusing users on Mac and Windows boxes.  The hope here is to make
it a little easier to discover that a Podman service is required.

This message is similar to what Docker puts out so people might under
stand it better.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@afbjorklund
Copy link
Contributor

afbjorklund commented Jan 9, 2021

Works for me.

podman-remote
Error: Cannot connect to the Podman socket, make sure there is a Podman REST API service running.: Get "http://d/v2.0.0/libpod/_ping": dial unix ///run/user/1000/podman/podman.sock: connect: no such file or directory

Similar enough to:

docker (rootless)
Cannot connect to the Docker daemon at unix:///run/user/1000/docker.sock. Is the docker daemon running?

@rhatdan
Copy link
Member Author

rhatdan commented Jan 10, 2021

@containers/podman-maintainers PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Jan 10, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 41613bd into containers:master Jan 10, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants