Default .Repository and .Tag values to <none>#7240
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Aug 10, 2020
Merged
Default .Repository and .Tag values to <none>#7240openshift-merge-robot merged 1 commit intocontainers:masterfrom
openshift-merge-robot merged 1 commit intocontainers:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM but I only gave it a very very quick glance. One favor: could you remove this line and re-push? podman/test/system/120-load.bats Line 31 in 0d4a269 |
Member
|
LGTM but someone more familiar with this code than I should review |
Member
|
/lgtm |
Member
|
Tests aren't hip @jwhonce |
Refactor the processing of Repository and Tag fields to default to <none>
when printing via --format flag. Previously, the default format would
print <none> but --format {{.Tag}} would not in some cases.
Fixes containers#7123
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the processing of Repository and Tag fields to default to
when printing via --format flag. Previously, the default format would
print but --format {{.Tag}} would not in some cases.
Fixes #7123
Signed-off-by: Jhon Honce jhonce@redhat.com