podman v2 remove bloat v2#5842
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Apr 16, 2020
Merged
Conversation
rhatdan
reviewed
Apr 16, 2020
libpod/define/config.go
Outdated
Member
There was a problem hiding this comment.
These need to be moved to containers.conf, but fine for now.
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
92ae82b to
daee066
Compare
jwhonce
reviewed
Apr 16, 2020
cmd/podmanV2/registry/config.go
Outdated
Member
There was a problem hiding this comment.
Refactoring to os.LookupEnv() would test for whether variable exists or not.
Member
|
/hold |
rid ourseleves of libpod references in v2 client Signed-off-by: Brent Baude <bbaude@redhat.com>
Member
|
/lgtm |
Member
Author
|
/hold cancel |
This was referenced Apr 16, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rid ourseleves of libpod references in v2 client
Signed-off-by: Brent Baude bbaude@redhat.com