enable dnsplugin for network create#4187
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Oct 29, 2019
Merged
enable dnsplugin for network create#4187openshift-merge-robot merged 1 commit intocontainers:masterfrom
openshift-merge-robot merged 1 commit intocontainers:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mheon
reviewed
Oct 3, 2019
mheon
reviewed
Oct 3, 2019
mheon
reviewed
Oct 3, 2019
ee387e1 to
dcf6a4c
Compare
Member
Author
|
ping, merge? |
Member
|
LGTM |
mheon
reviewed
Oct 28, 2019
when users create a new network and the dnsname plugin can be found by podman, we will enable container name resolution on the new network. there is an option to opt *out* as well. tests cannot be added until we solve the packaging portion of the dnsname plugin. Signed-off-by: baude <bbaude@redhat.com>
dcf6a4c to
2f6b8b9
Compare
Member
Author
|
fixed up |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when users create a new network and the dnsname plugin can be found by
podman, we will enable container name resolution on the new network.
there is an option to opt out as well.
tests cannot be added until we solve the packaging portion of the
dnsname plugin.
Signed-off-by: baude bbaude@redhat.com