Update c/image + existing tests to resolve the signing ambiguity#25096
Merged
openshift-merge-bot[bot] merged 4 commits intocontainers:mainfrom Jan 23, 2025
Merged
Conversation
https://github.com/containers/image/issues/2646 will track actually returning a meaningful error instead of these internal details. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This resolves the "signing ambiguity" by requiring that images must have a DiffID entry, and it must match, in partial pulls. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…ifferent methods" This reverts commit 1d7ec1e. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Read the full one, not the truncated one Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Luap99
approved these changes
Jan 23, 2025
Member
Luap99
left a comment
There was a problem hiding this comment.
/lgtm
Thanks merging this to unblock the vendor situation here
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of #25007, without the newly-added tests (discussed there); filed separately to allow updating c/image, so that others don’t have to resolve the test failures.
Does this PR introduce a user-facing change?