DO NOT MERGE: Test vendoring with precise pulled-image IDs#24462
Closed
mtrmac wants to merge 9 commits intocontainers:mainfrom
Closed
DO NOT MERGE: Test vendoring with precise pulled-image IDs#24462mtrmac wants to merge 9 commits intocontainers:mainfrom
mtrmac wants to merge 9 commits intocontainers:mainfrom
Conversation
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Regression test for containers#23550. Setting the TZDIR env should make no difference for the local timezone as this is not a real timezone name that is resolved from that directory. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Added in containers/buildah#5783 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
containers/common#2227 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
> go mod edit -replace github.com/containers/image/v5=github.com/mtrmac/image/v5@copy-resolve-destination Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 4, 2024
> go mod edit -replace github.com/containers/common=github.com/mtrmac/common@precise-pull-id Signed-off-by: Miloslav Trmač <mitr@redhat.com>
f55c51d to
5e0e083
Compare
This was referenced Nov 4, 2024
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
“TESTING: Drop the new composefs path” added to confirm a guess at the cause of #24463 . |
Contributor
Author
|
The c/image and c/common PRs have merged, and seem to be succeeding in #24447 , closing this PR in favor of ongoing work in the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #24447 + containers/image#2609 + containers/common#2209 .
Does this PR introduce a user-facing change?