DO NOT MERGE: Mitr’s zstd:chunked integration branch#24287
Closed
mtrmac wants to merge 9 commits intocontainers:mainfrom
Closed
DO NOT MERGE: Mitr’s zstd:chunked integration branch#24287mtrmac wants to merge 9 commits intocontainers:mainfrom
mtrmac wants to merge 9 commits intocontainers:mainfrom
Conversation
Contributor
mtrmac
commented
Oct 15, 2024
- Primarily to keep track what exactly is in flight, it’s getting a bit frenetic
- Also so that I can continue from here tomorrow without having to recreate this.
- And to run the tests in the standard environment and not my manually-created VM
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
f0a59b8 to
fc147f2
Compare
fc147f2 to
0606014
Compare
0606014 to
bd4fad4
Compare
This was referenced Oct 17, 2024
Merged
bd4fad4 to
34976b2
Compare
4c50b92 to
643f12a
Compare
67acf30 to
842c2bc
Compare
e639c82 to
e3d052e
Compare
9ed1e9a to
64207d9
Compare
Contributor
Author
|
Note to self: If/after containers/storage#2156 merges, this PR will need to re-enable |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
64207d9 to
5de48f5
Compare
Contributor
Author
|
Follow #24419 instead, we went with the “costly” correct approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.