CI: system tests: various small cleanups#24007
CI: system tests: various small cleanups#24007openshift-merge-bot[bot] merged 4 commits intocontainers:mainfrom
Conversation
...of high system load (such as when running parallel tests). Allow time for services to reach desired state, by retrying a few times in a loop. Signed-off-by: Ed Santiago <santiago@redhat.com>
...not just when running parallel Bats, because Bats does not provide any way to know if we're parallel. Signed-off-by: Ed Santiago <santiago@redhat.com>
Only in 000-TEMPLATE. I know I need to write more thorough documentation. I choose to defer that. Signed-off-by: Ed Santiago <santiago@redhat.com>
The "rm on stopping containers" test is flaking under high load, probably because I bumped up two timeouts in the healthcheck container that it relies on. Bump up this test's timeout as well. Signed-off-by: Ed Santiago <santiago@redhat.com>
Luap99
left a comment
There was a problem hiding this comment.
One big fix, running the registry container with --net=host. This should be much stabler.
That doesn't seem to be in this PR.
Anyway LGTM, thank you for the template fixes. This looks much better now.
| # When running under heavy load (e.g. parallel tests), it | ||
| # may take a little while for service to reach Started | ||
| for tries in $(seq 1 5); do | ||
| run journalctl "--since=$STARTED_TIME" --unit="$QUADLET_SERVICE_NAME" |
There was a problem hiding this comment.
AFAIK systemctl should wait for it to reach started state, but we know journald is not updating fast enough even after you write to it successfully (i.e. all the races in podman logs with journald) so there sadly doesn't seem to be any way avoid these loops
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Mostly to minimize flakes in parallel mode. And some documentation.