Skip to content

quadlet: support container network reusing#23814

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
ruihe774:quadlet-network-container
Sep 2, 2024
Merged

quadlet: support container network reusing#23814
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
ruihe774:quadlet-network-container

Conversation

@ruihe774
Copy link
Copy Markdown
Contributor

@ruihe774 ruihe774 commented Aug 30, 2024 •
edited
Loading 

A container created by Quadlet can now reuse the network of another container by setting `Network=another.container`

Luap99
Luap99 reviewed Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ygalblum PTAL

@ruihe774 ruihe774 force-pushed the quadlet-network-container branch 5 times, most recently from 31f9c84 to c029ca5 Compare August 30, 2024 12:59
ygalblum
ygalblum reviewed Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Code look good. An extra test will help keep the functionality in tact in the future

@ruihe774 ruihe774 force-pushed the quadlet-network-container branch from c029ca5 to a0dddce Compare August 30, 2024 13:30
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service bot commented Aug 30, 2024

Ephemeral COPR build failed. @containers/packit-build please check.

ygalblum
ygalblum approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@ygalblum
Copy link
Copy Markdown
Contributor

ygalblum commented Aug 30, 2024

Sorry, you'll need to manually rebase

@ruihe774
quadlet: support container network reusing
71fd157 
Signed-off-by: Misaki Kasumi <misakikasumi@outlook.com>
@ruihe774 ruihe774 force-pushed the quadlet-network-container branch from a0dddce to 71fd157 Compare August 30, 2024 13:35
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@ruihe774
Copy link
Copy Markdown
Contributor Author

ruihe774 commented Aug 30, 2024

I have no idea why int podman debian-13 rootless host sqlite failed.

@ygalblum
Copy link
Copy Markdown
Contributor

ygalblum commented Aug 30, 2024

I have no idea why int podman debian-13 rootless host sqlite failed.

Looks like a false negative. I've rerun it

Luap99
Luap99 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, ruihe774, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 29eb8ce into containers:main Sep 2, 2024
@edsantiago edsantiago mentioned this pull request Oct 9, 2024
Closed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 2, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ygalblum ygalblum ygalblum approved these changes

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ruihe774 @ygalblum @Luap99 @openshift-merge-robot