pr-should-include-tests: no more CI:DOCS override#23225
pr-should-include-tests: no more CI:DOCS override#23225openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
CI:DOCS is no more. Signed-off-by: Ed Santiago <santiago@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Luap99
left a comment
There was a problem hiding this comment.
Should we redefine the rules to better match our cirrus rules?
I think we could easily say unless a .go or .c was changed and not only in vendor/ or test/ then we do not need a test. To me this would help here to simply file the large
filtered_changes list
|
Possibly. I would need a thorough review of exceptions, such as .conf files, or Also, in the process of looking into this, I realized you need to add I'm OOTO today, will think about it more tomorrow. Thanks for the suggestion. |
I didn't though about .h because I thought all the symbol definitions are done in the go file in the special c comments but looks like you are right we have one .h file. I spin up a PR to add it. |
|
This PR LGTM |
|
/packit rebuild |
|
/lgtm |
CI:DOCS is no more.
Signed-off-by: Ed Santiago santiago@redhat.com