vendor: update to docker 27#23197
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Jul 12, 2024
Merged
Conversation
1 task
1 task
Fixes compile issues with new docker changes, then fix all the new depreciation warnings. Also there seem to be larger pre-existing problems with the /containers/json API output as the HostConfig field seems to be missing but I don't have time to deal with that currently. Note this does not include changes for the new docker API 1.46. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The new docker types have conflicting swagger:model names, there is both network.CreateResponse and container.CreateResponse. However both have a different fields (Warning and Warnings) and both are marked as required. The swagger generate sees both and somehow merges them but then only shows fields from one type but at the same time list all fields as required. This causes the swagger validation to fail: - "Warning" is present in required but not defined as property in definition "CreateResponse" To work around that we exlcude the netwok types from the swagger generation which makes it work again. Looking at the final type info in the browser it still shows the type onfo on the compat network endpints so it doesn't even loose any valuable information AFAICS. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
|
@mheon @containers/podman-maintainers PTAL |
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compile issues with new docker changes.
Also there seem to be larger pre-existing problems with the /containers/json API output as the HostConfig field seems to be missing but I don't have time to deal with that currently.
Note this does not include changes for the new docker API 1.46.
Does this PR introduce a user-facing change?