test/e2e: remove podman system service tests#23099
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Jun 25, 2024
Merged
test/e2e: remove podman system service tests#23099openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Two tests are skipped for a long time because they flaked to much, nobody cares about them and there are only debugging endpoints mostly so it is not critical either. The "of 2 seconds" tests isn't useful either. It waits up to 30s for the exit so it doesn't actually verify a proper timeout. Additionally we have similar checks in the system tests "podman system service - CORS enabled in logs" so I consider this safe to remove. Fixes containers#12624 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
And here I thought I could trick the needs tests check into thinking I added a test by removing a test file. Looks like I have to set the label then. |
Member
|
LGTM |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests are skipped for a long time because they flaked to much, nobody cares about them and there are only debugging endpoints mostly so it is not critical either.
The "of 2 seconds" tests isn't useful either. It waits up to 30s for the exit so it doesn't actually verify a proper timeout. Additionally we have similar checks in the system tests "podman system service - CORS enabled in logs" so I consider this safe to remove.
Fixes #12624
Does this PR introduce a user-facing change?