Skip to content

logformatter: handle Windows logs#22081

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
edsantiago:logformatter-windows
Mar 20, 2024
Merged

logformatter: handle Windows logs#22081
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
edsantiago:logformatter-windows

Conversation

@edsantiago
Copy link
Copy Markdown
Member

C-colon and backslashes and ^Ms oh my

Tested on sample failure and success logs, seems to work.

Signed-off-by: Ed Santiago santiago@redhat.com

None

C-colon and backslashes and ^Ms oh my

Tested on sample failure and success logs, seems to work.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2024
@packit-as-a-service
Copy link
Copy Markdown

Cockpit tests failed for commit f16ab11. @martinpitt, @jelly, @mvollmer please check.

@edsantiago
Copy link
Copy Markdown
Member Author

@containers/podman-maintainers this is a NOP until #21991 merges, but having it merged might help Mario test & debug that PR when he gets back next week.

@mheon
Copy link
Copy Markdown
Member

mheon commented Mar 19, 2024

LGTM

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8bfe9e4 into containers:main Mar 20, 2024
@edsantiago edsantiago deleted the logformatter-windows branch March 20, 2024 12:06
@edsantiago edsantiago mentioned this pull request May 15, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 19, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants