DO NOT MERGE: Run tests with Zstd:chunked compression default#21903
Closed
mtrmac wants to merge 6 commits intocontainers:mainfrom
Closed
DO NOT MERGE: Run tests with Zstd:chunked compression default#21903mtrmac wants to merge 6 commits intocontainers:mainfrom
mtrmac wants to merge 6 commits intocontainers:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 1, 2024
Member
|
WhooHoo Passed tests. |
|
A friendly reminder that this PR had no activity for 30 days. |
0e174ef to
7b39108
Compare
7b39108 to
84b528f
Compare
84b528f to
2e43b0a
Compare
Contributor
Author
|
6488a88 to
39a5f78
Compare
683d90a to
29b9c44
Compare
bcd6040 to
a41ef14
Compare
dafd485 to
48ed8d1
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
94b7437 to
0a33fda
Compare
0926906 to
9cbd4af
Compare
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The Go image is too old, at least in the CI images Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
9cbd4af to
0d4d473
Compare
Contributor
Author
|
We now (e.g. with #25007 ) always run at least some tests with Zstd, and there are no immediate plans to switch to it as default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #20633 ; now that #21571 is succeeding, let’s see what happens in the more complex case.
Does this PR introduce a user-facing change?