new vms, with rc6 rawhide kernel#21841
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Feb 27, 2024
Merged
new vms, with rc6 rawhide kernel#21841openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM |
Source: containers/automation_images#331 (comment) Kludgy VM build, because rawhide rc6 kernel is still not stable. I would like to merge this anyway, because the rawhide hang is hurting us badly. (I am not guaranteeing that this fixes the hang). Also: new Windows VM has WiX 3.14 (up from 3.11). Signed-off-by: Ed Santiago <santiago@redhat.com>
1990a55 to
c2a2113
Compare
edsantiago
commented
Feb 27, 2024
|
|
||
| # Pre-set to standard locations in-case build env does not refresh paths | ||
| $Env:Path="$Env:Path;C:\Program Files (x86)\WiX Toolset v3.11\bin;C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\bin;;C:\Program Files\Go\bin" | ||
| $Env:Path="$Env:Path;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\bin;;C:\Program Files\Go\bin" |
Member
Author
There was a problem hiding this comment.
Windows Experts PTAL. I don't know what WiX is, nor why it's needed, nor if 3.14 is compatible with 3.11.
Member
There was a problem hiding this comment.
It's a windows installer toolkit. 3.14 is a security update, so we want to grab it.
Member
|
/lgtm |
This was referenced Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: containers/automation_images#331 (comment)
Kludgy VM build, because rawhide rc6 kernel is still not stable.
I would like to merge this anyway, because the rawhide hang is
hurting us badly. (I am not guaranteeing that this fixes the hang).
Signed-off-by: Ed Santiago santiago@redhat.com