Adjust some tests to work with Zstd in containers.conf#21793
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Feb 22, 2024
Merged
Adjust some tests to work with Zstd in containers.conf#21793openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
Conversation
When we want the original image to be gzip, explicitly ask for that instead of assuming the containers.conf defaults do that. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
When we want the original image to be gzip, explicitly ask for that instead of assuming the containers.conf defaults do that. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Member
|
LGTM. All build tasks are Quay flakes. Restarted |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
37 tasks
Member
|
/lgtm |
Member
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are immediately-applicable parts of #21571 , so that tests which require gzip compression to be used don’t rely on the
containers.confdefault.That this does work with Zstd can be verified in #21571.
Does this PR introduce a user-facing change?