Skip to content

libpod: correctly map UID/GID for existing dirs#21611

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
giuseppe:correctly-chown-to-existing-dir-in-userns
Feb 13, 2024
Merged

libpod: correctly map UID/GID for existing dirs#21611
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
giuseppe:correctly-chown-to-existing-dir-in-userns

Conversation

@giuseppe
Copy link
Copy Markdown
Member

Closes: #21608

Does this PR introduce a user-facing change?

Now Podman chowns an existing volume to the correct uid/gid when the target path already exists in the container

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Feb 12, 2024

looks like cirrus CI isn't running correctly, can you force push to try to re trigger it.

@giuseppe giuseppe force-pushed the correctly-chown-to-existing-dir-in-userns branch 2 times, most recently from 9817d76 to 7001a66 Compare February 12, 2024 12:10
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 12, 2024

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
if the target mount path already exists and the container uses a user
namespace, correctly map the target UID/GID to the host values before
attempting a chown.

Closes: containers#21608

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the correctly-chown-to-existing-dir-in-userns branch from 7001a66 to c29fde2 Compare February 12, 2024 22:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@baude
Copy link
Copy Markdown
Member

baude commented Feb 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@baude
Copy link
Copy Markdown
Member

baude commented Feb 13, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9bf3cf6 into containers:main Feb 13, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 14, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong permissions on idmapped volumes created before starting the container

4 participants