not mounted layers should be reported as info not error#20456
Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom Oct 24, 2023
Merged
not mounted layers should be reported as info not error#20456openshift-ci[bot] merged 1 commit intocontainers:mainfrom
openshift-ci[bot] merged 1 commit intocontainers:mainfrom
Conversation
Member
Author
|
@edsantiago might help. |
Member
|
Code LGTM |
ashley-cui
reviewed
Oct 23, 2023
libpod/container_internal.go
Outdated
Member
There was a problem hiding this comment.
Suggested change
| logrus.Info("Storage for container %s is not mounted: %v", c.ID(), err) | |
| logrus.Infof("Storage for container %s is not mounted: %v", c.ID(), err) |
There is a potential race condition we are seeing where we are seeing a message about a removed container which could be caused by a non mounted container, this change should clarify which is causing it. Also if the container does not exists, just warn the user instead of reporting an error, not much the user can do. Fixes: containers#19702 [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a potential race condition we are seeing where we are seeing a message about a removed container which could be caused by a non mounted container, this change should clarify which is causing it.
Also if the container does not exists, just warn the user instead of reporting an error, not much the user can do.
Fixes: #19702
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?