CI: e2e: reenable containerized checkpoint tests#19449
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Jul 31, 2023
Merged
Conversation
And lo, a miracle occurred. Containerized checkpoint tests are no longer hanging. Reenable them. (Followup miracle: tests are still passing, after a year of not running!) Closes: containers#15015 Signed-off-by: Ed Santiago <santiago@redhat.com>
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
I'm confused about timings. These ran in 37:30 and 36:10 respectively, unlike my earlier attempt (see comments in #15015) where they took a lot longer. And another unrelated PR, #19419 which finished just now, ran 42:09 and 42:35. I can only conclude that there is great variation in containerized-testing run time. |
Member
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And lo, a miracle occurred. Containerized checkpoint tests are
no longer hanging. Reenable them.
(Followup miracle: tests are still passing, after a year of not
running!)
Closes: #15015
Signed-off-by: Ed Santiago santiago@redhat.com