[v4.4.1 rhel] Support podman --remote when Containerfile is not in context directory#19416
[v4.4.1 rhel] Support podman --remote when Containerfile is not in context directory#19416Romain-Geissler-1A wants to merge 1 commit intocontainers:v4.4.1-rhelfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
If this is specific to Podman on Windows - given we're using FCOS on the Windows VMs, and FCOS should be getting 4.6 very soon - is this required? |
Fixes: containers#18239 [NO NEW TESTS NEEDED] @test "podman build -f test" in test/system/070-build.bats Will test this. This was passing when run on a local system since the remote end was using the clients path to read the Containerfile The issue is it would not work in a podman machine since the Containerfile would/should be a different path. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
d2bfc1c to
65af13b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Romain-Geissler-1A The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
No we are using fully patched RHEL 9.2, and in some scenarios podman is used in --remote mode. |
|
Merged via #19632, closing |
Hi,
This is simply a cherry-pick of #18577 fixing #18239 on RHEL (we use RHEL 9.2, which is using podman 4.4.1). I have just opened the Red Hat case https://access.redhat.com/support/cases/#/case/03574665 to ask officially on Red Hat side for this backport, I have no RH Bugzilla ticket since I can't create them myself.
Note: I didn't cherry-pick the changes in
pkg/util/utils.gois this function doesn't exist in podman 4.4. I guess with podman 4.4 the handling of .dockerignore might still be a bit fishy when it's a symlink outside of the build tree and we use the remote podman, but it's not something we suffer from, so I have left this part of the diff away.I checked that this works fine inside containers, using commands similar to the one I wrote in the Red Hat case.
Cheers,
Romain